Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #6988 to 6.3: Registry file fsync improvements #7353

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

urso
Copy link

@urso urso commented Jun 18, 2018

Cherry-pick of PR #6988 to 6.3 branch. Original message:

  • Return error if Sync fails
  • Execute fsync on new parent directory
  • improve metrics:
    • registrar.writes.total: total number of registry write attempts
    • registrar.writes.fail: total number of failed write attempts
    • registrar.writes.success: total number of successfull write attempts

Resolves: #6792 (followup for #6877)

* Registry file fsync improvements

- Return error if Sync fails
- Execute fsync on new parent directory
- improve metrics:
  - registrar.writes.total: total number of registry write attempts
  - registrar.writes.fail: total number of failed write attempts
  - registrar.writes.success: total number of successfull write attempts

(cherry picked from commit 5916636)
@urso urso force-pushed the backport_6988_6.3 branch from 6e90d93 to 49924ad Compare June 18, 2018 12:07
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph merged commit e1fd62b into elastic:6.3 Jun 18, 2018
@urso urso deleted the backport_6988_6.3 branch February 19, 2019 18:36
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* Registry file fsync improvements

- Return error if Sync fails
- Execute fsync on new parent directory
- improve metrics:
  - registrar.writes.total: total number of registry write attempts
  - registrar.writes.fail: total number of failed write attempts
  - registrar.writes.success: total number of successfull write attempts

(cherry picked from commit f5179f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants