-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Fix offset field pointing at end of line for #6514 #7336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@original-brownbear can you add a changelog entry with this change?
@ph sure sec :) |
done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @original-brownbear
@ph np + thanks for the review: |
There is a test failing, I haven't see this one before, Can you take a look? Also don't worry for the backport, I will take care of it I have a few to do.
|
Something tell me it might be a timing issue, I will ask jenkins to run it again. |
jenkins test this please. |
@ph likely, last night it was green and I only added the changelog entry + rebase since the last time it ran. |
@ph I think it's a timing issue and i have seen the test failing before (which concerns me a bit). |
Fixes #6514. Didn't add a new test because I had to adjust that one test to reflect the change by adding EOL + message length before comparing to the stored file offset.