Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update haproxy.asciidoc #6857

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Update haproxy.asciidoc #6857

merged 1 commit into from
Apr 18, 2018

Conversation

OleOle7177
Copy link
Contributor

Fix stats port number

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@exekias exekias requested a review from jsoriano April 13, 2018 11:11
@jsoriano
Copy link
Member

@OleOle7177 good catch :) Could you please run make update to regenerate documentation and commit the changes?

And you'd also need to sign the CLA.

Thanks!

@OleOle7177
Update haproxy.asciidoc
de5eb0b 
Fix stats port number
@OleOle7177
Copy link
Contributor Author

@jsoriano thanks,
I've signed CLA and ran make update (no changes).

@ruflin
Copy link
Contributor

ruflin commented Apr 16, 2018

This PR is against 6.2. Normally we do PR's against master and then backport it from there.

@ruflin
Copy link
Contributor

ruflin commented Apr 16, 2018

@OleOle7177 Could you open the same PR against master? It's ok to keep this 6.2 too.

@OleOle7177
Copy link
Contributor Author

OleOle7177 commented Apr 16, 2018 •
edited
Loading

@ruflin Sure, here it is: #6869

@ruflin
Copy link
Contributor

ruflin commented Apr 16, 2018

jenkins, test it

1 similar comment
@ruflin
Copy link
Contributor

ruflin commented Apr 18, 2018

jenkins, test it

@ph
Copy link
Contributor

ph commented Apr 18, 2018

Jenkins test this please

@ruflin ruflin merged commit 91cfc08 into elastic:6.2 Apr 18, 2018
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@OleOle7177 @ruflin
Update haproxy.asciidoc (elastic#6857)
8db1c43 
Fix stats port number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano Awaiting requested review from jsoriano

Assignees
No one assigned
Labels
docs Metricbeat Metricbeat module review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OleOle7177 @elasticmachine @jsoriano @ruflin @ph @exekias