Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default metricsets in vsphere module #6676

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Set default metricsets in vsphere module #6676

merged 1 commit into from
Mar 28, 2018

Conversation

jsoriano
Copy link
Member

See #6668

@jsoriano jsoriano requested a review from ruflin March 27, 2018 09:33
@ruflin ruflin mentioned this pull request Mar 27, 2018
Closed
32 tasks
@jsoriano jsoriano force-pushed the vsphere-default-metricset branch from 88eec4b to 8ee518b Compare March 27, 2018 09:37
ruflin
ruflin reviewed Mar 27, 2018
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the docs about the default metricsets?

metricbeat/metricbeat.reference.yml Outdated
@@ -477,7 +477,6 @@ metricbeat.modules:

#------------------------------- vSphere Module ------------------------------
- module: vsphere
metricsets: ["datastore", "host", "virtualmachine"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep all metricsets in the reference file and also add enabled: true.

I assume there is no config.reference.yml in vshpere so we probably have to add one.

@jsoriano jsoriano force-pushed the vsphere-default-metricset branch from 8ee518b to 2308790 Compare March 27, 2018 16:44
@jsoriano jsoriano force-pushed the vsphere-default-metricset branch from 2308790 to 01c53c2 Compare March 27, 2018 16:47
@jsoriano
Copy link
Member Author

config.reference.yml added and docs updated

@ruflin ruflin merged commit 78f817f into elastic:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin left review comments

Assignees
No one assigned
Labels
docs Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @ruflin