Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move beat specific logic to docker-compose #665

Merged
merged 1 commit into from
Jan 8, 2016

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jan 7, 2016

This will make it possible to better reuse the base docker image.

@ruflin ruflin added the review label Jan 7, 2016
@@ -12,8 +12,13 @@ libbeat:
- LS_TLS_PORT=5055
- ES_USER=beats
- ES_PASS=testing
# Setup work environment
- LIBBEAT_PATH /go/src/github.com/elastic/beats/libbeat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work without =?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I will add the =

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ruflin ruflin force-pushed the docker-improvements branch from b394b41 to 0afb8e4 Compare January 8, 2016 09:52
env_file:
- build/test.env
working_dir: /go/src/github.com/elastic/beats/libbeat
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested using LIBBEAT_PATH variable here, doesn't work

@urso
Copy link

urso commented Jan 8, 2016

This re-enables integration tests using shield.

urso pushed a commit that referenced this pull request Jan 8, 2016
Move beat specific logic to docker-compose
@urso urso merged commit d409a02 into elastic:master Jan 8, 2016
@andrewkroh andrewkroh mentioned this pull request Jan 14, 2020
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants