Add plugin support for autodiscover builders, providers #6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
houndci-bot
reviewed
Feb 23, 2018
|
|
||
| var pluginKey = "libbeat.autodiscover.builder" | ||
|
|
||
| func Plugin(name string, b autodiscover.BuilderConstructor) map[string][]interface{} { |
There was a problem hiding this comment.
exported function Plugin should have comment or be unexported
|
|
||
| var pluginKey = "libbeat.autodiscover.provider" | ||
|
|
||
| func Plugin(name string, provider autodiscover.ProviderBuilder) map[string][]interface{} { |
There was a problem hiding this comment.
exported function Plugin should have comment or be unexported
vjsamuel
force-pushed
the
autodiscover_plugins
branch
from
8d39865 to
43b29b3
Compare
vjsamuel
force-pushed
the
autodiscover_plugins
branch
from
43b29b3 to
1035959
Compare
|
ok to test |
|
jenkins test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.