kubernetes watcher refactor #6159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
houndci-bot
reviewed
Jan 24, 2018
| @@ -0,0 +1,62 @@ | |||
| package add_kubernetes_metadata | |||
There was a problem hiding this comment.
don't use an underscore in package name
walktall
force-pushed
the
watcher-refactor
branch
from
3600fb8 to
b36b4a8
Compare
walktall
force-pushed
the
watcher-refactor
branch
3 times, most recently
from
32dabfc to
87f19c2
Compare
exekias
suggested changes
Jan 25, 2018
libbeat/common/kubernetes/watcher.go
Outdated
| p.pods[pod.Metadata.UID] = pod | ||
| // ugly reflect since ResourceList does not exposed Items | ||
| // can be avoid by using k8s.io/client-go | ||
| list := reflect.ValueOf(w.resourceList).Elem().FieldByName("Items") |
There was a problem hiding this comment.
You can avoid this if you create a new interface for resource list, and write adapters to get the Items from PodList and EventList, what do you think?
There was a problem hiding this comment.
Good idea! I will make a try. Thanks!
|
ok to test |
This was referenced Jan 25, 2018
some changes on code to adjust the v1.0.0
* be able to watch different resources * does not support cache now Fix bug: query pod meta won't refresh deleted map timeout metricbeat: using refactored watcher
|
@walktall This will need a rebase. |
walktall
force-pushed
the
watcher-refactor
branch
from
87f19c2 to
3a71526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from #6117
It does following items:
Update k8s vendor to get an abstract api for watching and listing.
Refactor watcher. The style is from client-go informer so that we can port to client-go without much effort in future. Also, it removes side effect in watcher, such as delay delete event and cache the resources, these side-effect should be implemented by caller who has that kind of requirement I think.
Although as mentioned by @exekias , bug fix for querying pod should be put in another pr, but I found it is hard to do that since moving cache out from watcher is part of refactor...
Event metricset in metricbeat now is using new refactored watcher.
@exekias PTAL~