Update generation of data.json files #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a recent change the generation of the example data.json events was changed to use the internal event json encoder. The effect of this was that the meta data was also added to the event and indentation changed which cause large diffs. I prefer to leave out the metadata out of the example events as the data should be the same as it ends up in elasticsearch and is documented in the fields.yml. As a first step, `data.json` for the system module were updated. Quite a few modules have outdate `data.json` files. I plan to update more in follow up PR's.
andrewkroh
approved these changes
Oct 12, 2017
| "time": 29700 | ||
| }, | ||
| "iostat": { | ||
| "avg_queue_size": 0.020000, |
There was a problem hiding this comment.
It would be nice to advertise these metrics in the example. Is there a config option we can set in TestData or do you want only the default fields in the example?
There was a problem hiding this comment.
I would definitively like to have these in too. I think the problem here is that I did run this on my Mac where these values are not available. Let me do a run for this data set in a linux container.
|
@andrewkroh Example from linux for diskio added. Can you have a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent change the generation of the example data.json events was changed to use the internal event json encoder. The effect of this was that the meta data was also added to the event and indentation changed which cause large diffs. I prefer to leave out the metadata out of the example events as the data should be the same as it ends up in elasticsearch and is documented in the fields.yml.
As a first step,
data.jsonfor the system module were updated.