Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5340 to 6.0: Improvements and fixes to the Host Overview dashboard #5351

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Oct 6, 2017

Cherry-pick of PR #5340 to 6.0 branch. Original message:

  • Use beat.name instead of beat.hostname in visualizations. See 6.0 Metricbeat dashboards switched name key? #5276 for
    the motivation
  • Add a "tip" widget that tells user how they can select another host.
  • Automatically set a search pattern of the form beat.name: "HOSTNAME" where
    HOSTNAME is the Beat name (hostname) that uploads the dashboards.

The way the last point works is that I saved the dashbaord using this filter:
beat.name:"CHANGEME_HOSTNAME". The kibana loader code does a string replacement
and replaces CHANGEME_HOSTNAME with the actual hostname. The disadvantage of this
approach (vs doing JSON parsing) is that we must remember to always save that
dashboard with the CHANGEME_HOSTNAME wildcard in place. I have added a unit test
to the system module that checks for that, so it should be relatively hard for
us to forget.

Closes #5276.

* Use `beat.name` instead of `beat.hostname` in visualizations. See elastic#5276 for
  the motivation
* Add a "tip" widget that tells user how they can select another host.
* Automatically set a search pattern of the form `beat.name: "HOSTNAME"` where
  HOSTNAME is the Beat name (hostname) that uploads the dashboards.

The way the last point works is that I saved the dashbaord using this filter:
`beat.name:"CHANGEME_HOSTNAME"`. The kibana loader code does a string replacement
and replaces `CHANGEME_HOSTNAME` with the actual hostname. The disadvantage of this
approach (vs doing JSON parsing) is that we must remember to always save that
dashboard with the `CHANGEME_HOSTNAME` wildcard in place. I have added a unit test
to the system module that checks for that, so it should be relatively hard for
us to forget.

Closes elastic#5276.

(cherry picked from commit 4778c51)
@@ -61,6 +64,14 @@ https://github.com/elastic/beats/compare/v6.0.0-rc1...master[Check the HEAD diff

*Metricbeat*

- Add graphite protocol metricbeat module. {pull}4734[4734]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog mess?

@tsg tsg force-pushed the backport_5340_6.0 branch from 54bd123 to af37fe1 Compare October 6, 2017 14:04
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@ruflin ruflin merged commit c087594 into elastic:6.0 Oct 9, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#5351)

* Use `beat.name` instead of `beat.hostname` in visualizations. See elastic#5276 for
  the motivation
* Add a "tip" widget that tells user how they can select another host.
* Automatically set a search pattern of the form `beat.name: "HOSTNAME"` where
  HOSTNAME is the Beat name (hostname) that uploads the dashboards.

The way the last point works is that I saved the dashbaord using this filter:
`beat.name:"CHANGEME_HOSTNAME"`. The kibana loader code does a string replacement
and replaces `CHANGEME_HOSTNAME` with the actual hostname. The disadvantage of this
approach (vs doing JSON parsing) is that we must remember to always save that
dashboard with the `CHANGEME_HOSTNAME` wildcard in place. I have added a unit test
to the system module that checks for that, so it should be relatively hard for
us to forget.

Closes elastic#5276.

(cherry picked from commit 8b6191e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants