Do not require template if index change and template disabled #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the elasticsearch index name is changed, its required to set a template. The error message was also shown when template itself are disabled. This is now changed that if templates are disabled, no error is returned. Closes elastic#5308
ruflin
added
bug
libbeat
needs_backport
|
Changelog entry? Or too small of a change? |
|
@tsg Good point, definitively should have one as it's a bug fix. Added. |
ruflin
removed
the
needs_backport
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Oct 5, 2017
…c#5319) * Do not require template if index change and template disabled If the elasticsearch index name is changed, its required to set a template. The error message was also shown when template itself are disabled. This is now changed that if templates are disabled, no error is returned. Closes elastic#5308 * Add Changelog (cherry picked from commit ce9e47b)
tsg
pushed a commit
that referenced
this pull request
Oct 6, 2017
…#5334) * Do not require template if index change and template disabled If the elasticsearch index name is changed, its required to set a template. The error message was also shown when template itself are disabled. This is now changed that if templates are disabled, no error is returned. Closes #5308 * Add Changelog (cherry picked from commit ce9e47b)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…c#5319) (elastic#5334) * Do not require template if index change and template disabled If the elasticsearch index name is changed, its required to set a template. The error message was also shown when template itself are disabled. This is now changed that if templates are disabled, no error is returned. Closes elastic#5308 * Add Changelog (cherry picked from commit b56accf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the elasticsearch index name is changed, its required to set a template. The error message was also shown when template itself are disabled. This is now changed that if templates are disabled, no error is returned.
Closes #5308