Fix packetbeat flaky tests #5200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
reviewed
Sep 19, 2017
packetbeat/beater/packetbeat.go
Outdated
|
|
||
| timeout := pb.config.ShutdownTimeout | ||
| if timeout > 0 { | ||
| defer func() { |
There was a problem hiding this comment.
The closure around the Sleep doesn't look to be necessary.
Moved the shutdown timeout after stopping the flows, but before stopping the transaction publishing. It needs to be after stopping the flows because the tests rely on the shutdown sequence to create flow reports.
tsg
force-pushed
the
fix_packetbeat_tests
branch
from
726aafe to
12dd7c2
Compare
tsg
added a commit
to tsg/beats
that referenced
this pull request
Nov 15, 2017
Moved the shutdown timeout after stopping the flows, but before stopping the transaction publishing. It needs to be after stopping the flows because the tests rely on the shutdown sequence to create flow reports. (cherry picked from commit c0de062)
exekias
pushed a commit
that referenced
this pull request
Nov 15, 2017
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Moved the shutdown timeout after stopping the flows, but before stopping the transaction publishing. It needs to be after stopping the flows because the tests rely on the shutdown sequence to create flow reports. (cherry picked from commit 954f3fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the shutdown timeout after stopping the flows, but before stopping
the transaction publishing. It needs to be after stopping the flows because
the tests rely on the shutdown sequence to create flow reports.