Add etcd module (#4970) #5176
Add etcd module (#4970) #5176
Conversation
|
Can one of the admins verify this patch? |
|
I run |
There was a problem hiding this comment.
I don't think the failure is related to fmt as it looks as following:
command [go test -tags integration -cover -coverprofile /tmp/gotestcover-027846761 github.com/elastic/beats/metricbeat/module/etcd/store]: exit status 1
docker-compose.yml is locked, waiting
docker-compose.yml is locked, waiting
--- FAIL: TestData (62.45s)
compose.go:64: Timeout waiting for services to be healthy
docker-compose.yml is locked, waiting
--- FAIL: TestFetch (61.52s)
compose.go:64: Timeout waiting for services to be healthy
FAIL
coverage: 80.0% of statements
@exekias might know here more.
@berfinsari It seems you checked in some files that should be under .gitignore. Can you remove them again?
metricbeat/_meta/beat.reference.yml
Outdated
| @@ -0,0 +1,452 @@ | |||
| ########################## Metricbeat Configuration ########################### | |||
There was a problem hiding this comment.
I think this file was added by accident?
| @@ -0,0 +1,6769 @@ | |||
| - key: common | |||
There was a problem hiding this comment.
This file should not be checked in.
|
Hi @berfinsari, thank you for contributing! As @ruflin pointed out, there is an issue with the testing container, you will need to add a valid HEALTHCHECK, for some reason the current one is failing, so we get a timeout waiting for the service to be ready to run tests |
| @@ -0,0 +1,6 @@ | |||
| - module: etcd | |||
| metricsets: ["leader", "self", "store"] | |||
| enabled: false | |||
There was a problem hiding this comment.
Can you drop the enabled field? We leave it to the default now
|
jenkins, test it |
|
I'll have a look to the healthcheck |
…i/beats into metricbeat-etcd-module
|
I've fixed conflicts and health check ( |
|
jenkins test it please |
|
jenkins test it, please |
|
I fixed the container health issue, but tests seem to be broken, @berfinsari do you want to have a look? I can take it tomorrow if not |
|
@exekias Thanks for the healthcheck, i check the integration tests |
|
jenkins, test it |
metricbeat/module/etcd/_meta/env
Outdated
| @@ -0,0 +1,2 @@ | |||
| ETCD_HOST=localhost | |||
There was a problem hiding this comment.
I think you want to put ETCD_HOST=etcd here, it will probably fix tests
|
jenkins test it please |
|
Finally tests are green 💚, thank you for your contribution!! |
The Etcd module uses Etcd v2 API to collect metrics.