Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong timestamp in heartbeat events #4855

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Fix wrong timestamp in heartbeat events #4855

merged 1 commit into from
Aug 11, 2017

Conversation

urso
Copy link

@urso urso commented Aug 9, 2017

Resolves: #4851

@urso urso added bug Heartbeat needs_backport PR is waiting to be backported to other branches. labels Aug 9, 2017
tsg
tsg approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@urso urso force-pushed the fix/heartbeat-event-timestamp branch from a32c8e7 to 5915577 Compare August 9, 2017 14:35
@urso urso added the review label Aug 9, 2017
@andrewkroh
Copy link
Member

LGTM. But I merged the other PR and it caused a conflict.

@urso urso force-pushed the fix/heartbeat-event-timestamp branch from 5915577 to 91b8b10 Compare August 10, 2017 20:42
@andrewkroh andrewkroh merged commit e8f55ba into elastic:master Aug 11, 2017
@urso urso mentioned this pull request Aug 11, 2017
Merged
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Aug 11, 2017
@urso urso deleted the fix/heartbeat-event-timestamp branch February 19, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg approved these changes

Assignees
No one assigned
Labels
bug Heartbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urso @andrewkroh @tsg