Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added required alias property to documentation #4800

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

wovas
Copy link
Contributor

@wovas wovas commented Aug 1, 2017

Trying to start metricbeat for capturing performance counters with default configuration form documentation fails complaining on absent "alias" field in counters definitions.

Trying to start metricbeat for capturing performance counters with default configuration form documentation fails complaining on absent "alias" field in counters definitions.
@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@andrewkroh
Copy link
Member

@wovas Thanks for the contribution. Could you please sign the contributor license agreement (CLA).

@andrewkroh andrewkroh added the needs CLA User must sign the Elastic Contributor License before review. label Aug 2, 2017
@wovas
Copy link
Contributor Author

wovas commented Aug 2, 2017

@andrewkroh, CLA has been signed.

@andrewkroh andrewkroh removed the needs CLA User must sign the Elastic Contributor License before review. label Aug 2, 2017
@andrewkroh andrewkroh merged commit 44d6f9d into elastic:master Aug 2, 2017
@andrewkroh
Copy link
Member

andrewkroh commented Sep 7, 2017

It looks like alias was actually removed in #4502 so it should not be included in the documentation. alias hasn't been used since 6.0.0-beta1 so maybe testing was done on an earlier version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants