Add instance_name config option for perfmon metricset #4655
Conversation
|
Can one of the admins verify this patch? |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
martinscholz83
changed the title
martinscholz83
force-pushed
the
perfmon-instance-name
branch
from
b6dd5fc to
ee0b3ce
Compare
| @@ -10,6 +10,10 @@ You must configure queries for the Windows performance counters that you wish | |||
| to collect. The example below collects processor time and disk writes. | |||
| With `format` you can set the output format for a specific counter. Possible values are | |||
| `float` and `long`. If nothing is selected the default value is `float`. | |||
| There is also an optional/required option `instance_name`. | |||
There was a problem hiding this comment.
Saying " optional/required option" seems like a contradiction. I'd reword this section to say something like the following (I've fixed a few grammatical issues):
With instance_name, you can specify the name of the instance. Use this setting when:
- You want to use an instance name that is different from the computed name. For example,
Totalinstead of_Total. - You specify a counter that has no instance. For example,
\TCPIP Performance Diagnostics\IPv4 NBLs/sec indicated without prevalidation.
I'm not sure what you mean by "For wildcard queries this option is needles." Do you mean that the setting has no effect?
There was a problem hiding this comment.
thanks @dedemorton for the text. Yes, for wildcard queries this setting has no effect.
|
Many thanks @maddin2016 for the contribution! |
(cherry picked from commit 4a927b4)
I have stumbled about this while testing some counters. In #4502 we add some new config options
instance_labelandmeasurement_label. The value forinstance_labelis computed by extracting the instance name from the query. This works fine as long as you define a wildcard query or your query contains a instance. For example\Processor Information(_Total)\% Processor Time. But if you define a query like this\TCPIP Performance Diagnostics\IPv4 NBLs/sec indicated without prevalidationthere is no instance name. So we need an extra option to set the instance name. This has the side effect that we can change the instance name for normal queries.\Processor Information(_Total)\% Processor Timewe can name the instanceTotalortotalor whatever we want. I have changed the docs. Can you please check the grammar. Thanks!