Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update elastic-agent-libs to v0.18.8 #42804

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Feb 20, 2025

Proposed commit message

This PR updates elastic-agent-libs to the most recent version.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@mauri870 mauri870 self-assigned this Feb 20, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 20, 2025
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 20, 2025
Copy link
Contributor

mergify bot commented Feb 20, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mauri870? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mauri870 mauri870 added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Feb 20, 2025
@mauri870
Copy link
Member Author

Test failures are related to a breaking change in libs.
Fixed in elastic/elastic-agent-libs#283.

@mauri870 mauri870 force-pushed the bump-libs branch 2 times, most recently from 2ccca1f to b9fabb1 Compare February 24, 2025 11:16
@mauri870 mauri870 marked this pull request as ready for review February 28, 2025 19:51
@mauri870 mauri870 requested a review from a team as a code owner February 28, 2025 19:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@cmacknz cmacknz added backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches and removed backport-8.x Automated backport to the 8.x branch with mergify labels Feb 28, 2025
@strawgate
Copy link
Contributor

@mauri870 I have merged a change to agent-libs for improved warning logging during SSL handling that I would love backported as well, would you be open to carving a version that includes elastic/elastic-agent-libs#285 (already merged) and bumping to that version in this PR? So that we avoid doing bumping + backports twice for the lib update

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick request changes since I approved without realizing the changelog is going in the wrong place.

@mauri870
Copy link
Member Author

mauri870 commented Mar 5, 2025

I have merged a change to agent-libs for improved warning logging during SSL handling that I would love backported as well, would you be open to carving a version that includes elastic/elastic-agent-libs#285 (already merged) and bumping to that version in this PR? So that we avoid doing bumping + backports twice for the lib update.

I just tagged v0.18.8 in libs to include your change.

@mauri870 mauri870 requested a review from cmacknz March 5, 2025 11:30
@mauri870
Copy link
Member Author

mauri870 commented Mar 5, 2025

/test

1 similar comment
@mauri870
Copy link
Member Author

mauri870 commented Mar 5, 2025

/test

@mauri870 mauri870 changed the title chore: update elastic-agent-libs chore: update elastic-agent-libs to v0.18.8 Mar 5, 2025
@cmacknz
Copy link
Member

cmacknz commented Mar 5, 2025

Thanks, will approve once CI is passing.

@mauri870
Copy link
Member Author

mauri870 commented Mar 6, 2025

Thanks, will approve once CI is passing.

I finally got a green CI! Just waiting on your approval. Thanks!

@mauri870 mauri870 enabled auto-merge (squash) March 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9.0 Automated backport to the 9.0 branch backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants