-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MaxOpenRequests to kafka output config #42515
base: main
Are you sure you want to change the base?
Conversation
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
===== `max_open_requests` | ||
|
||
The maximum number of unacknowledged requests the client will send on a single connection before blocking. | ||
Throughput can improve but message ordering is not guaranteed if Idempotent is disabled, see: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont expose idempotent as a setting and the default value for this also impacts message ordering so I think we can get rid of the comment about idempotent and message ordering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed reference to idempotent, but I think it's worth keeping the note about the impact on message ordering. If we aren't explicit about the lack of guarantee, it will be easy for someone to get the wrong idea
Co-authored-by: William Easton <[email protected]>
better documentation Co-authored-by: William Easton <[email protected]>
*Filebeat* | ||
|
||
- Added max_open_requests to kafka output config {pull}42515[42515] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't it apply to all beats? Here it's listed as only affecting filebeat
Enhancement
Proposed commit message
Added MaxOpenRequests with a default of 5 to configuration options. This will increase throughput, but could have an impact on event ordering.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs