-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate document_type in filebeat 5.5 #4225
Conversation
144428b
to
a9c6161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFG
Can we also add a |
I left it out because in case of 10 prospectors, the message would be printed out 10 times and if someone is using reloading even more. But we could use sync.Once perhaps to eliminate the problem. |
@ruflin i'd prefer to do that, because for the migration guide we're going to recommend people to check the Deprecation logs before upgrading, so it would be good to catch this. Even printing it multiple times wouldn't be bad, but I think sync.Once should be pretty easy. |
Ok, will add it. |
`_type` is removed in elasticsearch 6.0 and `document_type` is removed in filebeat 6.0. Use `fields` instead.
a9c6161
to
2be852a
Compare
New version pushed with deprecation message. It is now only happening once as this is part of the harvester and otherwise we would see this quite often. |
when document_type is deprecated, in the kafka output, how to use %{[type]} for conditional topics? |
_type
is removed in elasticsearch 6.0 anddocument_type
is removed in filebeat 6.0. Usefields
instead.