Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate document_type in filebeat 5.5 #4225

Merged
merged 1 commit into from
May 9, 2017

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented May 5, 2017

_type is removed in elasticsearch 6.0 and document_type is removed in filebeat 6.0. Use fields instead.

@ruflin ruflin force-pushed the deprecate-document_type branch from 144428b to a9c6161 Compare May 5, 2017 11:20
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@tsg
Copy link
Contributor

tsg commented May 5, 2017

Can we also add a log.Deprecate if the config has a value?

@ruflin
Copy link
Contributor Author

ruflin commented May 5, 2017

I left it out because in case of 10 prospectors, the message would be printed out 10 times and if someone is using reloading even more. But we could use sync.Once perhaps to eliminate the problem.

@tsg
Copy link
Contributor

tsg commented May 9, 2017

@ruflin i'd prefer to do that, because for the migration guide we're going to recommend people to check the Deprecation logs before upgrading, so it would be good to catch this. Even printing it multiple times wouldn't be bad, but I think sync.Once should be pretty easy.

@ruflin
Copy link
Contributor Author

ruflin commented May 9, 2017

Ok, will add it.

`_type` is removed in elasticsearch 6.0 and `document_type` is removed in filebeat 6.0. Use `fields` instead.
@ruflin ruflin force-pushed the deprecate-document_type branch from a9c6161 to 2be852a Compare May 9, 2017 11:15
@ruflin
Copy link
Contributor Author

ruflin commented May 9, 2017

New version pushed with deprecation message. It is now only happening once as this is part of the harvester and otherwise we would see this quite often.

@andrewkroh andrewkroh merged commit cf5ed8d into elastic:5.x May 9, 2017
@oldcodeoberyn
Copy link

when document_type is deprecated, in the kafka output, how to use %{[type]} for conditional topics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants