[system/cpu,core] - Disable performance counter by default to unblock agent CI

[VihasMakwana]

Alternative to #42042.

This is a temporary fix as CI on elastic-agent's main is broken https://buildkite.com/elastic/elastic-agent-extended-testing/builds/5390#0193c17f-c655-422a-8dc9-ae5a7a40fdbd.

This most likely happened because user not having enough permissions to read from performance counter. I'll do some more digging and fix the underlying issue.

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @VihasMakwana? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[VihasMakwana]

I'll do some more digging and fix the underlying issue.

Sadly, the only way to fix it is by add the user to "Performance Monitoring Users" group on Windows.
When I was testing this in unprivileged mode on my VM, the elastic-agent user was already a member of the group, so I overlooked this detail.

@leehinman @cmacknz what should be the best way to proceed?

1. Disabling this by default and updating the docs with required info.
   • I tend to prefer this option i.e. merging this PR.
2. Enabling them and throwing warning, if any error is encountered.
   • i.e. this PR

[cmacknz]

Whether to use performance counters or not needs to become an explicit configuration exposed in the system integration as well as the module. Because this is configuration, in theory in the agent tests affected by this an agent PR that sets his same configuration to false could be made directly in agent so we don't have to wait for a new DRA build. Since it isn't in the integration yet, the fleet overrides API could be used.

Ideally, we would add ourselves to the Performance Monitor Users group automatically, but this will not help agents that were not already installed, so we need a way to handle that. Maybe just having it be configurable with the default value controlled by whether we are in the right group.

The DataDog agent installer adds itself to the performance monitor users group and some others for example https://docs.datadoghq.com/agent/guide/windows-agent-ddagent-user/

[cmacknz]

Please create an issue to track this problem so we don't lose the discussion in this PR

[VihasMakwana]

Please create an issue to track this problem so we don't lose the discussion in this PR

Sure.