Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16](backport #41794) Remove ManagerV2 unnecessary reload when apm tracing config is nil #41955

Merged
merged 2 commits into from
Dec 9, 2024
Merged

[8.16](backport #41794) Remove ManagerV2 unnecessary reload when apm tracing config is nil #41955

merged 2 commits into from
Dec 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 9, 2024

Proposed commit message

Remove unnecessary reload due to apm tracing config change in ManagerV2 when apm tracing config changes from nil to nil.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Trigger input unit config change. With this PR, there should be no Reloading APM tracing logged when reloading.

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #41794 done by [Mergify](https://mergify.com).

@carsonip @mergify
Remove ManagerV2 unnecessary reload when apm tracing config is nil (#…
3a5d518 
…41794)

Remove unnecessary reload due to apm tracing config change in ManagerV2 when apm tracing config changes from nil to nil.

(cherry picked from commit 2dbb606)
@mergify mergify bot requested a review from a team as a code owner December 9, 2024 14:57
@mergify mergify bot added the backport label Dec 9, 2024
@mergify mergify bot requested review from belimawr and VihasMakwana and removed request for a team December 9, 2024 14:57
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2024
@carsonip carsonip self-requested a review December 9, 2024 15:00
carsonip
carsonip reviewed Dec 9, 2024
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@carsonip carsonip added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@carsonip carsonip requested a review from cmacknz December 9, 2024 15:07
@carsonip carsonip merged commit 8f24f9e into 8.16 Dec 9, 2024
58 checks passed
@carsonip carsonip deleted the mergify/bp/8.16/pr-41794 branch December 9, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsonip carsonip carsonip approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees

@carsonip carsonip

Labels
backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elasticmachine @carsonip