-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional stats fields for Elasticsearch #41944
Conversation
This actually worsens performance This reverts commit ccfe071.
This reverts commit de840a3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off for Eng Prod to unblock this. Eng Prod shouldn't be codeowner here, fixing that in https://github.com/elastic/beats/pull/41597/files
* Perform an additional _settings API call for Elasticsearch module * Added filter_path for cluster state & index settings fetch * Added index creation version (cherry picked from commit 16c753c)
* Perform an additional _settings API call for Elasticsearch module * Added filter_path for cluster state & index settings fetch * Added index creation version (cherry picked from commit 16c753c) Co-authored-by: Alexis Charveriat <[email protected]>
* Perform an additional _settings API call for Elasticsearch module * Added filter_path for cluster state & index settings fetch * Added index creation version (cherry picked from commit 16c753c)
* Perform an additional _settings API call for Elasticsearch module * Added filter_path for cluster state & index settings fetch * Added index creation version
* Perform an additional _settings API call for Elasticsearch module * Added filter_path for cluster state & index settings fetch * Added index creation version (cherry picked from commit 16c753c) Co-authored-by: Alexis Charveriat <[email protected]>
This aims to replace #41652
Proposed commit message
Adds
creation_date
andtier_preference
fields forelasticsearch.index
dataset.This will be necessary for further development through elastic/integrations#11656
Checklist
I have made corresponding change to the default configuration filesN/ACHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Regarding the documentation, the example document is copied from the
data.json
file, accurately modified in this PR.Another modification in the
integrations
repo will be required (for this file)Disruptive User Impact
This "shouldn't" have an impact on end-users, this doesn't alter existing behavior but only adds 2 new fields that will be exposed in the gathered Elasticsearch monitoring stats.
Author's Checklist
How to test this PR locally
You can run the integration against any cluster (with
xpack
or otherwise) and check that the generated index stats documents have the two new fields:creation_date
tier_preference
Screenshots
Performance
Below is a table presenting the impact of the addition of the extra API call, compared to fetching from cluster state (#41652) or the current code
Bear in mind the target monitored cluster is in
us-east-1
whereas I monitored from EMEA central (Switzerland), the two round trips probably contribute to a lot of the latency. I could run an additional test from a local cloud instance, if we want to refine the measurements.