Invoke m.Run on TestMain and fix test flakiness

[AndersonQ]

Proposed commit message

invoke m.Run on TestMain and reduce test flakiness

Some TestMain were not running any tests as they did not invoke m.Run. This change fixes that.

Also other tests were presenting some flakyness, therefore this change also attempts to fix the flakiness by setting really unique IDs for filestream tests and increasing a timeout for TestTranslateGUIDWithLDAP.

The following 4 packages were not running any test as the TestMain was not invoking m.Run() to actually run the test. The packages were:

• filebeat/autodiscover/builder/hints
• filebeat/processor/add_kubernetes_metadata
• metricbeat/autodiscover/appender/kubernetes/token
• metricbeat/autodiscover/builder/hints

Checklist

• My code follows the style guidelines of this project
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

• N/A

How to test this PR locally

Run the test for the affected packages, the tests should run.

go test -v ./filebeat/autodiscover/builder/hints
go test -v ./filebeat/processor/add_kubernetes_metadata
go test -v ./metricbeat/autodiscover/appender/kubernetes/token
go test -v ./metricbeat/autodiscover/builder/hints

Before the fix:

❯ go test -v .
ok  	github.com/elastic/beats/v7/filebeat/autodiscover/builder/hints	0.530s

After the fix

❯ go test -v .
=== RUN   TestUnpackCopiesDefault
--- PASS: TestUnpackCopiesDefault (0.00s)
=== RUN   TestGenerateHints
--- PASS: TestGenerateHints (0.01s)
=== RUN   TestGenerateHintsWithPaths
--- PASS: TestGenerateHintsWithPaths (0.00s)
PASS
ok  	github.com/elastic/beats/v7/filebeat/autodiscover/builder/hints	0.172s

Related issues

• Investigate if it is possible to prevent inputs with non-unique IDs from being templated by autodiscovery #41881

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @AndersonQ? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[mauri870]

Good catch!

[AndersonQ]

I've seem more than once tests failing like that (see output below). So as this PR is already to fix tests, let's fix those as well.

2024-12-04 17:57:18 CEST	=== FAIL: filebeat/input/filestream TestFilestreamCloseRemoved (unknown)
2024-12-04 17:57:18 CEST	panic: name fake-ID already used
2024-12-04 17:57:18 CEST	
2024-12-04 17:57:18 CEST	goroutine 279 [running]:
2024-12-04 17:57:18 CEST	github.com/elastic/elastic-agent-libs/monitoring.panicErr(...)
2024-12-04 17:57:18 CEST		/opt/buildkite-agent/.asdf/installs/golang/1.22.9/packages/pkg/mod/github.com/elastic/[email protected]/monitoring/registry.go:257
2024-12-04 17:57:18 CEST	github.com/elastic/elastic-agent-libs/monitoring.(*Registry).Add(0xc00060dd80, {0xf4003b?, 0x0?}, {0x10f39a0, 0xc00295ad40}, 0xe0?)
2024-12-04 17:57:18 CEST		/opt/buildkite-agent/.asdf/installs/golang/1.22.9/packages/pkg/mod/github.com/elastic/[email protected]/monitoring/registry.go:155 +0xcc
2024-12-04 17:57:18 CEST	github.com/elastic/elastic-agent-libs/monitoring.(*Registry).NewRegistry(0xc00060dd80, {0xf4003b, 0x7}, {0x0?, 0x0?, 0xf45374?})
2024-12-04 17:57:18 CEST		/opt/buildkite-agent/.asdf/installs/golang/1.22.9/packages/pkg/mod/github.com/elastic/[email protected]/monitoring/registry.go:94 +0x15d
2024-12-04 17:57:18 CEST	github.com/elastic/beats/v7/libbeat/monitoring/inputmon.NewInputRegistry({0xf43ba8, 0xa}, {0xf4003b, 0x7}, 0xe7faa0?)
2024-12-04 17:57:18 CEST		/opt/buildkite-agent/builds/bk-agent-prod-gcp-1733331086222823672/elastic/filebeat/libbeat/monitoring/inputmon/input.go:65 +0x38c
2024-12-04 17:57:18 CEST	github.com/elastic/beats/v7/filebeat/input/filestream/internal/input-logfile.NewMetrics({0xf4003b, 0x7})
2024-12-04 17:57:18 CEST		/opt/buildkite-agent/builds/bk-agent-prod-gcp-1733331086222823672/elastic/filebeat/filebeat/input/filestream/internal/input-logfile/metrics.go:66 +0x94
2024-12-04 17:57:18 CEST	github.com/elastic/beats/v7/filebeat/input/filestream/internal/input-logfile.(*managedInput).Run(_, {0xc00f8624f0, {0xf4003b, 0x7}, {0x0, 0x0}, {{0x0, 0x0}, {0x0, 0x0}, ...}, ...}, ...)
2024-12-04 17:57:18 CEST		/opt/buildkite-agent/builds/bk-agent-prod-gcp-1733331086222823672/elastic/filebeat/filebeat/input/filestream/internal/input-logfile/input.go:67 +0x205
2024-12-04 17:57:18 CEST	github.com/elastic/beats/v7/filebeat/input/filestream.(*inputTestingEnvironment).startInput.func1(0xc0004e9f90?, 0xc0004e9f90?)
2024-12-04 17:57:18 CEST		/opt/buildkite-agent/builds/bk-agent-prod-gcp-1733331086222823672/elastic/filebeat/filebeat/input/filestream/environment_test.go:132 +0x163
2024-12-04 17:57:18 CEST	created by github.com/elastic/beats/v7/filebeat/input/filestream.(*inputTestingEnvironment).startInput in goroutine 159
2024-12-04 17:57:18 CEST		/opt/buildkite-agent/builds/bk-agent-prod-gcp-1733331086222823672/elastic/filebeat/filebeat/input/filestream/environment_test.go:128 +0x11b

added more changes