Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic if libbeat processors are registered more than once #41857

Merged

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Dec 2, 2024

Proposed commit message

Prevent panic if libbeat plugins are loaded more than once.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@leehinman leehinman requested a review from a team as a code owner December 2, 2024 20:03
@leehinman leehinman requested review from rdner and faec December 2, 2024 20:03
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Dec 2, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 2, 2024
@leehinman leehinman force-pushed the 41475_state_preventing_multiple_receivers branch from ee56cab to 495ae03 Compare December 2, 2024 20:12
@leehinman leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 2, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
@leehinman leehinman changed the title don't panic loading twice Don't panic if libbeat processors are registered more than once Dec 2, 2024
@leehinman leehinman force-pushed the 41475_state_preventing_multiple_receivers branch from 495ae03 to 2ac0b3d Compare December 3, 2024 14:59
@leehinman leehinman merged commit ab0f3c8 into elastic:main Dec 3, 2024
142 checks passed
mergify bot pushed a commit that referenced this pull request Dec 3, 2024
(cherry picked from commit ab0f3c8)
leehinman added a commit that referenced this pull request Dec 4, 2024
(cherry picked from commit ab0f3c8)

Co-authored-by: Lee E Hinman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libbeat: global init state prevents multiple instances of filebeat receiver
6 participants