[8.x](backport #41824) Fix Kafka output panic at startup #41828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #40794 the Connectable interface was changed to include a
context.Context
argument, causing all clients with a Connect() that weren't updated to have aContext(context.Context)
method instead to fail the NetworkClient interface check inbeats/libbeat/publisher/pipeline/client_worker.go
Lines 64 to 70 in 367d94e
This made it so that the Kafka and Redis outputs no longer counted as NetworkClients, bypassing the initial call to
Connect()
that was there previously atbeats/libbeat/publisher/pipeline/client_worker.go
Line 143 in 367d94e
In the case of Kafka the Connect call never happening makes the output panic on the first call to
Publish
because there is no producer.Raising without tests to make sure nothing else was missed while I figure out the best test for this that isn't totally contrived, because the problem is in the publisher pipeline and the output specific tests don't hook in at that level. This is how the problem was originally missed.The PR has been updated with an integration test to reproduce the problem: #41824 (comment)
This is an automatic backport of pull request #41824 done by [Mergify](https://mergify.com).