Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default value of kafka version to 2.1.0 #41662

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Nov 18, 2024

This sets default value of kafka version to 2.1.0

Closes #41474

@khushijain21 khushijain21 requested a review from a team as a code owner November 18, 2024 12:37
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2024
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 18, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 18, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 18, 2024
@khushijain21 khushijain21 removed the backport-8.x Automated backport to the 8.x branch with mergify label Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 18, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 18, 2024
@khushijain21
Copy link
Contributor Author

@pierrehilbert we don't to backport this to 8.X correct? And this will be introduced in 9.0. Let me know

@pierrehilbert
Copy link
Collaborator

Correct, we shouldn't backport this to 8.x branch.

@pierrehilbert pierrehilbert added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b kafka-min-version upstream/kafka-min-version
git merge upstream/main
git push upstream kafka-min-version

@rdner
Copy link
Member

rdner commented Nov 19, 2024

@faec I'm afraid I can miss some required changes elsewhere, could you please have a quick look?

@rdner rdner requested a review from faec November 19, 2024 13:00
@khushijain21 khushijain21 merged commit 93fc239 into elastic:main Nov 20, 2024
142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default version for Kafka output to 2.1.0
5 participants