-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libbeat] Go Benchmarks comparing compress/gzip and klauspost/compress #41584
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
@khushijain21 I think we need a better representation of the results in the description. Would be nice to have a more readable table / graphs and a summary / conclusion at the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the linter issue needs to be fixed and there are a few comments to address.
@khushijain21 from the table looks like the compression level 4 always wins. I wonder what's the payload size difference between I think it's important to compare encoded sizes, otherwise if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We just need to fix the changelog formatting, there is an extra empty line before the new entry and the missing empty line after the new entry.
#41584) (#41669) - This PR replaces compress/gzip to klauspost/compress/gzip - We send data to the _bulk endpoint and benchmark the results (cherry picked from commit 18e256f) Co-authored-by: Khushi Jain <[email protected]>
Results
We send data to the
_bulk
endpoint and benchmark the results with and without the https://github.com/klauspost/compress library.Results with varying compression level and event size
Time per operation
Bytes per operation
Summary
With the ' klauspost ' library, there is a significant speedup across tests for most compression levels with varying event sizes. But with compression level 9, it is slower - resulting in a performance drop of around 12-16%.
This PR also replaces
compress/gzip
toklauspost/compress/gzip
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues