Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbeat] Add translate_ldap_attribute processor #41472

Merged
merged 13 commits into from
Nov 6, 2024

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 29, 2024

Proposed commit message

Adds a processor that will connect to an LDAP server in order to translate attributes from one to another. Typically used in Active Directory environments to translate GUID's to their respective common names.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Looking for best approach to add automated tests for this.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 29, 2024
@marc-gr marc-gr added enhancement Team:Security-Windows Platform Windows Platform Team in Security Solution backport-8.x Automated backport to the 8.x branch with mergify and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 29, 2024
@marc-gr marc-gr force-pushed the feat/add-translate-guid branch 2 times, most recently from eea555b to a375d7b Compare October 29, 2024 10:43
@marc-gr marc-gr force-pushed the feat/add-translate-guid branch from a104776 to b5688d6 Compare October 31, 2024 10:15
@marc-gr marc-gr marked this pull request as ready for review October 31, 2024 10:17
@marc-gr marc-gr requested review from a team as code owners October 31, 2024 10:17
@marc-gr marc-gr requested review from rdner and VihasMakwana October 31, 2024 10:17
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@marc-gr marc-gr changed the title [libbeat] Add translate_guid processor [libbeat] Add translate_ldap_attribute processor Oct 31, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 31, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Asciidoc part. 🚀
Just one super small suggestion.

@cmacknz
Copy link
Member

cmacknz commented Nov 1, 2024

Update the CODEOWNERS to have the security windows platform team be the explicitly owners of the new processor please :)

@marc-gr marc-gr requested a review from a team as a code owner November 4, 2024 07:40
@marc-gr marc-gr requested a review from mauri870 November 4, 2024 07:40
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving codeowner change

@marc-gr marc-gr merged commit 87687a5 into elastic:main Nov 6, 2024
183 checks passed
@marc-gr marc-gr deleted the feat/add-translate-guid branch November 6, 2024 14:21
mergify bot pushed a commit that referenced this pull request Nov 6, 2024
* Add translate_guid processor

* Add cache to docs

* Add more config options

* Add integration test for translate_guid processor

* Rename processor

* Fix reference to use new processor name

* Rename field in test

* Add codeowners, and various format fixes

* Fix test lint issues

* Update libbeat/processors/translate_ldap_attribute/docs/translate_ldap_attribute.asciidoc

(cherry picked from commit 87687a5)
marc-gr added a commit that referenced this pull request Nov 6, 2024
* Add translate_guid processor

* Add cache to docs

* Add more config options

* Add integration test for translate_guid processor

* Rename processor

* Fix reference to use new processor name

* Rename field in test

* Add codeowners, and various format fixes

* Fix test lint issues

* Update libbeat/processors/translate_ldap_attribute/docs/translate_ldap_attribute.asciidoc

(cherry picked from commit 87687a5)

Co-authored-by: Marc Guasch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Windows Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] GUID Translation
7 participants