-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libbeat] Add translate_ldap_attribute processor #41472
Conversation
eea555b
to
a375d7b
Compare
a104776
to
b5688d6
Compare
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
libbeat/processors/translate_ldap_attribute/docs/translate_ldap_attribute.asciidoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the Asciidoc part. 🚀
Just one super small suggestion.
Update the CODEOWNERS to have the security windows platform team be the explicitly owners of the new processor please :) |
libbeat/processors/translate_ldap_attribute/docs/translate_ldap_attribute.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving codeowner change
* Add translate_guid processor * Add cache to docs * Add more config options * Add integration test for translate_guid processor * Rename processor * Fix reference to use new processor name * Rename field in test * Add codeowners, and various format fixes * Fix test lint issues * Update libbeat/processors/translate_ldap_attribute/docs/translate_ldap_attribute.asciidoc (cherry picked from commit 87687a5)
* Add translate_guid processor * Add cache to docs * Add more config options * Add integration test for translate_guid processor * Rename processor * Fix reference to use new processor name * Rename field in test * Add codeowners, and various format fixes * Fix test lint issues * Update libbeat/processors/translate_ldap_attribute/docs/translate_ldap_attribute.asciidoc (cherry picked from commit 87687a5) Co-authored-by: Marc Guasch <[email protected]>
Proposed commit message
Adds a processor that will connect to an LDAP server in order to translate attributes from one to another. Typically used in Active Directory environments to translate GUID's to their respective common names.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Looking for best approach to add automated tests for this.