Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event deletion in the memqueue #41340

Closed
wants to merge 2 commits into from
Closed

Fix event deletion in the memqueue #41340

wants to merge 2 commits into from

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Oct 21, 2024

Proposed commit message

Fix event deletion in the memqueue

#39584 accidentally removed Batch.FreeEntries, which was responsible for actually deleting events from the queue. Since that change, events are never deleted from the queue, just overwritten. As a result, we consume noticably more memory wherever the event rate is significantly smaller than the queue size.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@swiatekm swiatekm added the bug label Oct 21, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 21, 2024
Copy link
Contributor

mergify bot commented Oct 21, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @swiatekm? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Oct 21, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 21, 2024
@swiatekm swiatekm added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team and removed backport-8.x Automated backport to the 8.x branch with mergify labels Oct 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 21, 2024
@swiatekm swiatekm added needs_team Indicates that the issue/PR needs a Team:* label Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Oct 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 21, 2024
@swiatekm swiatekm added backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Oct 21, 2024
@swiatekm swiatekm requested review from faec and belimawr October 21, 2024 14:39
@swiatekm
Copy link
Contributor Author

This PR will soon be closed in favor of a superior alternative. Until then, I'm keeping it here for reference.

@swiatekm
Copy link
Contributor Author

Closing in favor of #41356.

@swiatekm swiatekm closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify bug Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant