Switch K8s tests to Wolfi by default and make it configurable #41222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we test Wolfi-based images but there is now an environment variable `IMAGE_MODIFIER` that can be used for specifying different image prefixes when calling the make target. Also, now the test verifies the actual container readiness and deletes resources after itself.
rdner
added
enhancement
Team:Elastic-Agent
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
pierrehilbert
added
the
Team:Cloudnative-Monitoring
|
nit: Maybe add to the descprition that something like Looks good |
gizas
approved these changes
Oct 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
By default we test Wolfi-based images but there is now an environment variable `IMAGE_MODIFIER` that can be used for specifying different image prefixes when calling the make target. Also, now the test verifies the actual container readiness and deletes resources after itself. (cherry picked from commit 3492089) # Conflicts: # deploy/kubernetes/auditbeat-kubernetes.yaml # deploy/kubernetes/filebeat-kubernetes.yaml # deploy/kubernetes/heartbeat-kubernetes.yaml # deploy/kubernetes/metricbeat-kubernetes.yaml
rdner
added a commit
that referenced
this pull request
Oct 15, 2024
#41237) By default we test Wolfi-based images but there is now an environment variable `IMAGE_MODIFIER` that can be used for specifying different image prefixes when calling the make target. Also, now the test verifies the actual container readiness and deletes resources after itself. (cherry picked from commit 3492089) # Conflicts: # deploy/kubernetes/auditbeat-kubernetes.yaml # deploy/kubernetes/filebeat-kubernetes.yaml # deploy/kubernetes/heartbeat-kubernetes.yaml # deploy/kubernetes/metricbeat-kubernetes.yaml Co-authored-by: Denis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
By default we test Wolfi-based images but there is now an environment variable
IMAGE_MODIFIERthat can be used for specifying different image prefixes when calling the make target.Also, now the test verifies the actual container readiness and deletes resources after itself.
How to test this PR locally
Run the packaging command in the following folders:
(put your architecture instead)
Then you need a running K8s cluster with the pre-configured
kubectl. I used Docker Desktop.then go to
./deploy/kubernetesand runby default we test against the Wolfi-based images but it can be switched by:
or test the main image instead:
The output should be something like this:
This means K8s manifests were successfully generated, applied and the containers were running successfully.
Check the generated manifests for the images to have
-wolfisuffix:Related issues