Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing backup and delete for AWS S3 polling mode #41071

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Missing backup and delete for AWS S3 polling mode #41071

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc894a8
Missing backup and delete for AWS S3 polling mode
kaiyan-sheng Oct 1, 2024
15c3576
add changelog
kaiyan-sheng Oct 2, 2024
a739278
Merge branch 'main' into s3_input_backup
kaiyan-sheng Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
- Ensure netflow custom field configuration is applied. {issue}40735[40735] {pull}40730[40730]
- Fix replace processor handling of zero string replacement validation. {pull}40751[40751]
- Fix long filepaths in diagnostics exceeding max path limits on Windows. {pull}40909[40909]
- Add backup and delete for AWS S3 polling mode feature back. {pull}41071[41071]


*Heartbeat*
Expand Down
4 changes: 4 additions & 0 deletions x-pack/filebeat/input/awss3/s3_input.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ func (in *s3PollerInput) workerLoop(ctx context.Context, workChan <-chan *s3Fetc

// Metrics
in.metrics.s3ObjectsAckedTotal.Inc()

if finalizeErr := objHandler.FinalizeS3Object(); finalizeErr != nil {
in.log.Errorf("failed finalizing objects from S3 bucket (manual cleanup is required): %w", finalizeErr)
}
}
}

Expand Down