x-pack/filebeat/input/cel: make http functions always available #40912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Filebeat
botelastic
bot
added
needs_team
HTTP functions were previously conditional on the resource URL being an HTTP/HTTPS URL. In hindsight, this offers no benefits and can result in confusing errors when the end user enters an invalid URL for an HTTP-based integration. Instead of a URL-related or HTTP-related error, the user is given a compilation error indicating that the HTTP-related function that are being called (and they may not be aware of in any way) are not valid references. So let's just always make them available.
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
andrewkroh
approved these changes
Sep 20, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
HTTP functions were previously conditional on the resource URL being an HTTP/HTTPS URL. In hindsight, this offers no benefits and can result in confusing errors when the end user enters an invalid URL for an HTTP-based integration. Instead of a URL-related or HTTP-related error, the user is given a compilation error indicating that the HTTP-related function that are being called (and they may not be aware of in any way) are not valid references. So let's just always make them available. (cherry picked from commit 14337dd)
Merged
6 tasks
efd6
added a commit
that referenced
this pull request
Sep 24, 2024
…) (#40933) HTTP functions were previously conditional on the resource URL being an HTTP/HTTPS URL. In hindsight, this offers no benefits and can result in confusing errors when the end user enters an invalid URL for an HTTP-based integration. Instead of a URL-related or HTTP-related error, the user is given a compilation error indicating that the HTTP-related function that are being called (and they may not be aware of in any way) are not valid references. So let's just always make them available. (cherry picked from commit 14337dd) Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
HTTP functions were previously conditional on the resource URL being an HTTP/HTTPS URL. In hindsight, this offers no benefits and can result in confusing errors when the end user enters an invalid URL for an HTTP-based integration. Instead of a URL-related or HTTP-related error, the user is given a compilation error indicating that the HTTP-related function that are being called (and they may not be aware of in any way) are not valid references. So let's just always make them available.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs