-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS CloudWatch Metrics] Record previous endTime to use for next collection period #40870
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ection period (#40870) (#40929) This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time. This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger. (cherry picked from commit cef78ed) Co-authored-by: kaiyan-sheng <[email protected]>
…ection period (#40870) (#40930) This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time. This PR also changes log.logger from cloudwatch to aws.cloudwatch to match the other logger. (cherry picked from commit cef78ed) Co-authored-by: kaiyan-sheng <[email protected]>
Proposed commit message
This PR is to record the previous endTime from the previous collection period to use for calculating the next collection start time and end time.
With using the previous endTime as the new startTime, we will not skip time range in collection.
This PR also changes log.logger from
cloudwatch
toaws.cloudwatch
to match the other logger.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
N/A. User will see no gap in collection startTime and endTime, should be an enhancement.
How to test this PR locally
./metricbeat modules enable aws
aws.yml
: