Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15](backport #40714) [vSphere] add triggered alarm to existing metricsets. #40835

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[8.15](backport #40714) [vSphere] add triggered alarm to existing metricsets. #40835

merged 2 commits into from
Sep 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 15, 2024 •
edited by zube bot
Loading

Description

Added alert.names field to fetch information related to alert in all the metricsets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

This is an automatic backport of pull request #40714 done by [Mergify](https://mergify.com).

@niraj-elastic @mergify
[vSphere] add triggered alarm to existing metricsets. (#40714)
2177780 
* add alert names

* update host metricset

* add alert metrics to all the metricsets

* add changelog entry

* update data_test

* add triggerd alarms

* added entity name

* mage check

---------

Co-authored-by: Niraj Rathod <[email protected]>
Co-authored-by: Kush Rana <[email protected]>
Co-authored-by: harnish-elastic <[email protected]>
(cherry picked from commit 885a2db)
@mergify mergify bot requested a review from a team as a code owner September 15, 2024 12:34
@mergify mergify bot added the backport label Sep 15, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 15, 2024
@botelastic
Copy link

botelastic bot commented Sep 15, 2024

This pull request doesn't have a Team:<team> label.

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 16, 2024

This pull request has not been merged yet. Could you please review and merge it @ishleenk17? 🙏

@ishleenk17 ishleenk17 merged commit 29ccd48 into 8.15 Sep 16, 2024
28 of 29 checks passed
@ishleenk17 ishleenk17 deleted the mergify/bp/8.15/pr-40714 branch September 16, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmsr shmsr shmsr approved these changes

Assignees

@ishleenk17 ishleenk17

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shmsr @ishleenk17 @niraj-elastic