Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: ironbank images are not anymore in the package file #40786

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 12, 2024

Proposed commit message

#40524 removed the need to update dev-tools/packaging/packages.yml - registry.access.redhat.com/ubi9/ubi-minimal is not used anymore.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@v1v v1v self-assigned this Sep 12, 2024
@v1v v1v requested a review from a team as a code owner September 12, 2024 10:42
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2024
@botelastic
Copy link

botelastic bot commented Sep 12, 2024

This pull request doesn't have a Team:<team> label.

@v1v v1v enabled auto-merge (squash) September 12, 2024 10:43
Copy link
Contributor

mergify bot commented Sep 12, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 12, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@v1v v1v added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Sep 12, 2024
@v1v v1v merged commit df31948 into elastic:main Sep 12, 2024
9 checks passed
@rdner
Copy link
Member

rdner commented Sep 12, 2024

@v1v I just saw this linked to my PR. The ironbank images -ubi were not changed in #40524 they are still present on main:

- &docker_ubi_spec
extra_vars:
image_name: "{{.BeatName}}-ubi"
from: "--platform=linux/amd64 docker.elastic.co/ubi9/ubi-minimal"
- &docker_arm_ubi_spec
extra_vars:
image_name: "{{.BeatName}}-ubi"
from: "--platform=linux/arm64 docker.elastic.co/ubi9/ubi-minimal"

- os: linux
arch: amd64
types: [docker]
spec:
<<: *docker_spec
<<: *docker_ubi_spec
<<: *elastic_docker_spec
<<: *elastic_license_for_binaries

- os: linux
arch: arm64
types: [docker]
spec:
<<: *docker_arm_spec
<<: *docker_arm_ubi_spec
<<: *elastic_docker_spec
<<: *elastic_license_for_binaries

The *-ubi images are still produced as you can see on the list in my PR description.

@v1v
Copy link
Member Author

v1v commented Sep 12, 2024

@v1v I just saw this linked to my PR. The ironbank images -ubi were not changed in #40524 they are still present on main:

I was probably misled by what I meant. I meant that https://github.com/elastic/beats/pull/40524/files#diff-9e8bcd1359f1e06bbdf2c89db711c6c400ed4142cf9764ff03e6e963013122e5R184-R186

Moved from registry.access.redhat.com/ubi9/ubi-minimal:9.4 to docker.elastic.co/ubi9/ubi-minimal

So in this case, there is no an explicit version in the docker image but latest, and it does not use registry.access.redhat.com anymore.

The automation I built for bumping versions was for searching registry.access.redhat.com, but since it's no longer available, we don't need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants