-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change maintainer label to opencontainers in Dockerfile #40736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old way of specifying maintainers in a Dockerfile was to use the MAINTAINER instruction. This is now deprecated and the maintainer label was used instead. Nowadays the recommended way to set a maintainer is through the `org.opencontainers.image.authors` label. See https://docs.docker.com/reference/build-checks/maintainer-deprecated/.
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
|
Probably needs to happen in the |
leehinman
approved these changes
Sep 11, 2024
faec
approved these changes
Sep 11, 2024
Thanks, I'll make sure to check the agent as well! |
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
The old way of specifying maintainers in a Dockerfile was to use the MAINTAINER instruction. This is now deprecated and the maintainer label was used instead. Nowadays the recommended way to set a maintainer is through the `org.opencontainers.image.authors` label. See https://docs.docker.com/reference/build-checks/maintainer-deprecated/. (cherry picked from commit 4cc11f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
cleanup
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The old way of specifying maintainers in a Dockerfile was to use the MAINTAINER instruction. This is now deprecated and the maintainer label was used instead.
Nowadays the recommended way to set a maintainer is through the
org.opencontainers.image.authors
label.See https://docs.docker.com/reference/build-checks/maintainer-deprecated/.
Author's Checklist