-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fields to use mapstr in vSphere virtualmachine metricset #40707
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but left a few comments.
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
NOTE: |
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
NOTE: |
* Convert fields to mapstr * lint changes * Address comments, update changelog * lint change * Address CI failure (cherry picked from commit e7637c0) # Conflicts: # metricbeat/module/vsphere/fields.go # metricbeat/module/vsphere/virtualmachine/_meta/data.json # metricbeat/module/vsphere/virtualmachine/data.go # metricbeat/module/vsphere/virtualmachine/data_test.go # metricbeat/module/vsphere/virtualmachine/virtualmachine.go
* Convert fields to mapstr * lint changes * Address comments, update changelog * lint change * Address CI failure (cherry picked from commit e7637c0)
…lmachine metricset (#40832) * Update fields to use mapstr in vSphere virtualmachine metricset (#40707) * Convert fields to mapstr * lint changes * Address comments, update changelog * lint change * Address CI failure (cherry picked from commit e7637c0) * Update CHANGELOG.next.asciidoc --------- Co-authored-by: Ishleen Kaur <[email protected]>
…machine metricset (#40724) * Update fields to use mapstr in vSphere virtualmachine metricset (#40707) * Convert fields to mapstr * lint changes * Address comments, update changelog * lint change * Address CI failure (cherry picked from commit e7637c0) # Conflicts: # metricbeat/module/vsphere/fields.go # metricbeat/module/vsphere/virtualmachine/_meta/data.json # metricbeat/module/vsphere/virtualmachine/data.go # metricbeat/module/vsphere/virtualmachine/data_test.go # metricbeat/module/vsphere/virtualmachine/virtualmachine.go * resolved conflicts * fix data.json * update fields.go --------- Co-authored-by: Ishleen Kaur <[email protected]> Co-authored-by: Kush Rana <[email protected]>
Proposed commit message
See title
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.