Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Add Synthetics to wolfi image #40689

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

emilioalvap
Copy link
Collaborator

Proposed commit message

Adding required dependencies to run Synthetics to Wolfi-based heartbeat images, from wolfi-os package manager.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

How to test this PR locally

  • Build heartbeat wolfi image locally with:
DEV=true SNAPSHOT=true PLATFORMS=linux/amd64 PACKAGES=docker mage package
  • Create the following monitor configuration:
heartbeat.monitors:
- type: browser
  id: korean-characters
  name: korean_characters_test
  schedule: '@every 1m'
  source:
    inline:
      script: |-
        step("first", async () => {
          await page.goto('https://www.naver.com/');
        });
- type: browser
  id: chinese-characters
  name: chinese_characters_test
  schedule: '@every 1m'
  source:
    inline:
      script: |-
        step("first", async () => {
          await page.goto('https://baike.baidu.com/');
        });
- type: browser
  id: russian-characters
  name: russian_characters_test
  schedule: '@every 1m'
  source:
    inline:
      script: |-
        step("first", async () => {
          await page.goto('https://yandex.ru/');
        });
- type: browser
  id: arabic-characters
  name: arabic_characters_test
  schedule: '@every 1m'
  source:
    inline:
      script: |-
        step("first", async () => {
          await page.goto('https://www.bbc.com/arabic');
        });
  • Run and check monitors are executed correctly with status: up.
  • Run again, this time with root user and check monitors are executed correctly with status: up.

Support for additional fonts has been tested with elastic-agent-complete with same dependencies installed:
image
image
image
image
image

Related issues

@emilioalvap emilioalvap added enhancement backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Sep 4, 2024
@emilioalvap emilioalvap requested a review from rdner September 4, 2024 11:46
@emilioalvap emilioalvap requested a review from a team as a code owner September 4, 2024 11:46
@emilioalvap emilioalvap requested a review from belimawr September 4, 2024 11:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 4, 2024
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for doing it so quickly!

@emilioalvap emilioalvap merged commit 2b5384a into elastic:main Sep 4, 2024
123 checks passed
{{ $beatHome }}/.synthetics \
{{ $beatHome }}/.npm \
{{ $beatHome }}/.cache \
| xargs -IDIR sh -c 'mkdir -m 0775 -p DIR'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for different file permission here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an ongoing initiative to remove elastic-agent from the root group, this is just a reflection of that: elastic/elastic-agent#4087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add synthetics to the new Wolfi image of Heartbeat
4 participants