Kubernetes processor enhancements #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
enhancement
in progress
exekias
force-pushed
the
k8s-processor-enhancements
branch
from
1cb827e to
c9ef182
Compare
ruflin
approved these changes
Apr 20, 2017
exekias
force-pushed
the
k8s-processor-enhancements
branch
3 times, most recently
from
6795072 to
24fbb1c
Compare
exekias
added
review
and removed
in progress
|
should by ready! |
exekias
force-pushed
the
k8s-processor-enhancements
branch
from
24fbb1c to
79a2c9d
Compare
ruflin
reviewed
Apr 24, 2017
| description: > | ||
| Kubernetes namespace | ||
|
|
||
| - name: kubernetes.labels |
| description: > | ||
| Kubernetes labels map | ||
|
|
||
| - name: kubernetes.annotations |
There was a problem hiding this comment.
This shoud be singular. Reason if someone is going to "read it" it will be kubernetes.label.testlabel=18
There was a problem hiding this comment.
I've been reading https://www.elastic.co/guide/en/beats/libbeat/5.3/event-conventions.html and also saw how we do it in docker module: https://github.com/elastic/beats/blob/master/metricbeat/module/docker/container/_meta/data.json#L13
It sounds more natural to me to have labels as plural. It's like you are naturally selecting a label by name from the labels dict, what do you think?
There was a problem hiding this comment.
labels sounds better to me too, but I am fine also with singular.
* Move kubernetes processor to root processors folder * Restart watch call on error * Flag kubernetes proccesor as beta * Fix config validation for `in_cluster` cases * Add kubernetes metadata fields * Put kubernetes processor fields under a common namespace
exekias
force-pushed
the
k8s-processor-enhancements
branch
from
79a2c9d to
0808b39
Compare
monicasarbu
approved these changes
Apr 25, 2017
|
jenkins, retest it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add several small enhancements and fixes to kubernetes processor (WIP):
in_clusterusekubernetesnamespaceRelated to #4027