refactor fleet mode detection and storage #40667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
leehinman
added
backport-skip
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
VihasMakwana
approved these changes
Sep 2, 2024
leehinman
force-pushed
the
refactor_fleet_mode_detection
branch
from
3a18c3c to
f846c31
Compare
5 tasks
jlind23
pushed a commit
that referenced
this pull request
Oct 7, 2024
leehinman
added a commit
that referenced
this pull request
Oct 7, 2024
* Revert "refactor fleet mode detection and storage (#40667)" This reverts commit 3309620. * fix import (cherry picked from commit 60bdc6a) Co-authored-by: Lee E Hinman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
refactor fleet mode detection and storage
Currently the fleet mode is only detected by looking at the command
line flags. This refactor keeps that behavior but also adds the
ability to set the value based independently. This is important if
you were to embed a Beat within elastic-agent and have it behave as
fleet managed.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
There should be no user observed change.
Author's Checklist
How to test this PR locally
elastic-agenttest suite with agentbeat built from this patch.Related issues
Use cases
Screenshots
Logs