Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: fix slice init length #40637

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Bug: fix slice init length #40637

merged 6 commits into from
Nov 4, 2024

Conversation

dufucun
Copy link
Contributor

@dufucun dufucun commented Aug 28, 2024

Proposed commit message

fix slice init length

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@dufucun dufucun requested a review from a team as a code owner August 28, 2024 08:49
@dufucun dufucun requested review from AndersonQ and faec August 28, 2024 08:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 28, 2024
@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Aug 28, 2024 •
edited
Loading

💚 CLA has been signed

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 28, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @dufucun? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@dufucun
Copy link
Contributor Author

dufucun commented Aug 28, 2024

❌ Author of the following commits did not sign a Contributor Agreement: 14cb6ed

Please, read and sign the above mentioned agreement if you want to contribute to this project

signed

@mauri870
Copy link
Member

Thanks!

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 28, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 28, 2024
@dufucun
Copy link
Contributor Author

dufucun commented Aug 28, 2024

Thanks for your review!

@pierrehilbert
Copy link
Collaborator

/test

@pierrehilbert
Copy link
Collaborator

run docs-build

@ycombinator ycombinator added backport-v8.x backport-8.15 Automated backport to the 8.15 branch with mergify and removed backport-8.15 Automated backport to the 8.15 branch with mergify labels Sep 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@v1v v1v added backport-8.15 Automated backport to the 8.15 branch with mergify and removed backport-v8.x labels Sep 11, 2024
@ycombinator
Copy link
Contributor

@dufucun, it looks like the linter is complaining about this:

  Error: libbeat/processors/ratelimit/limit.go:49:41: SA1030: 'bitSize' argument is invalid, must be either 32 or 64 (staticcheck)
  	v, err := strconv.ParseFloat(valueStr, 8)
  	                                       ^
  
  Error: issues found
  Ran golangci-lint in 429865ms

@mauri870
Copy link
Member

mauri870 commented Sep 11, 2024 •
edited
Loading

@ycombinator The linter error should be fixed once #40753 is merged.

Edit: I just merged the PR and rebased this branch.

@pierrehilbert
Copy link
Collaborator

/test

@pierrehilbert
Copy link
Collaborator

run docs-build

@pierrehilbert
Copy link
Collaborator

/test

@pierrehilbert
Copy link
Collaborator

run docs-build

@mauri870
Copy link
Member

Would be good to get this merged. The changes are very simple and logically correct. The CI errors in the previous builds appear to be unrelated with the changes.

@mauri870 mauri870 enabled auto-merge (squash) October 11, 2024 15:09
@pierrehilbert
Copy link
Collaborator

/test

@pierrehilbert
Copy link
Collaborator

run docs-build

@cuishuang cuishuang mentioned this pull request Oct 14, 2024
Open
@dufucun
Copy link
Contributor Author

dufucun commented Oct 16, 2024

Thanks

@pierrehilbert
Copy link
Collaborator

/test

@pierrehilbert
Copy link
Collaborator

/test

@pierrehilbert
Copy link
Collaborator

run docs-build

1 similar comment
@pierrehilbert
Copy link
Collaborator

run docs-build

@mauri870 mauri870 merged commit 092929b into elastic:main Nov 4, 2024
141 checks passed
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@dufucun @mergify
bug: fix slice init length (#40637)
7574114 
Signed-off-by: dufucun <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Anderson Queiroz <[email protected]>
(cherry picked from commit 092929b)
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@dufucun @mergify
bug: fix slice init length (#40637)
8a18c3a 
Signed-off-by: dufucun <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Anderson Queiroz <[email protected]>
(cherry picked from commit 092929b)
This was referenced Nov 4, 2024
Open
Merged
@pierrehilbert pierrehilbert added the backport-8.16 Automated backport with mergify label Nov 4, 2024
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@dufucun @mergify
bug: fix slice init length (#40637)
68c8672 
Signed-off-by: dufucun <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Anderson Queiroz <[email protected]>
(cherry picked from commit 092929b)
@mergify mergify bot mentioned this pull request Nov 4, 2024
Merged
6 tasks
pierrehilbert pushed a commit that referenced this pull request Nov 4, 2024
@mergify @dufucun
bug: fix slice init length (#40637) (#41514)
b1d05e8 
Signed-off-by: dufucun <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Anderson Queiroz <[email protected]>
(cherry picked from commit 092929b)

Co-authored-by: dufucun <[email protected]>
pierrehilbert pushed a commit that referenced this pull request Nov 5, 2024
@mergify @dufucun
bug: fix slice init length (#40637) (#41515)
a91af5b 
Signed-off-by: dufucun <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Anderson Queiroz <[email protected]>
(cherry picked from commit 092929b)

Co-authored-by: dufucun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauri870 mauri870 mauri870 approved these changes

@faec faec faec approved these changes

@AndersonQ AndersonQ AndersonQ approved these changes

Assignees

@dufucun dufucun

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dufucun @mauri870 @elasticmachine @pierrehilbert @ycombinator @AndersonQ @faec @v1v