Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14](backport #40389) [tests][filebeat] fix flaky unit test cases #40406

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[8.14](backport #40389) [tests][filebeat] fix flaky unit test cases #40406

merged 1 commit into from
Aug 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 31, 2024 •
edited by zube bot
Loading

  • Bug fix

Proposed commit message

  • Current behaviour:
    • In unit test case, we use /logs/* pattern.
    • This is problematic, because we can also read the ndjson file (which we shouldn't, as it's the output file) and this would cause test case failure.
  • This PR fixes the behaviour.
    • Use logs/*.log as the pattern
    • Use Runner: 'xyz' has stopped to determine the stoppage instead of Stopping runner. The later would fail if there are transient errors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #40389 done by [Mergify](https://mergify.com).

@VihasMakwana @mergify
[tests][filebeat] fix flaky unit test cases (#40389)
f0bf0a8 
* fix: fix flaky unit test cases

* fix: fix test_reload_same_config

(cherry picked from commit 4fbf1b1)
@mergify mergify bot requested a review from a team as a code owner July 31, 2024 15:20
@mergify mergify bot added the backport label Jul 31, 2024
@mergify mergify bot requested review from belimawr and VihasMakwana and removed request for a team July 31, 2024 15:20
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 31, 2024
@ycombinator ycombinator added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 31, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 31, 2024
@pierrehilbert pierrehilbert merged commit c181443 into 8.14 Aug 1, 2024
26 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.14/pr-40389 branch August 1, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@VihasMakwana VihasMakwana

Labels
backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elasticmachine @pierrehilbert @ycombinator @VihasMakwana