-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Add docs for Auditbeat add_session_metadata processor #40252
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Outdated
Show resolved
Hide resolved
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Outdated
Show resolved
Hide resolved
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Outdated
Show resolved
Hide resolved
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Show resolved
Hide resolved
8111746
to
a074116
Compare
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Outdated
Show resolved
Hide resolved
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Wolf <[email protected]>
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Show resolved
Hide resolved
Please review and comment so that we can nail down the content. |
Builds locally, but fails PR checks.buildkite/docs-build-pr — Failed
Notes to self @karenzone:
Update - What's going on?(Updated 2024-0805, M) Thank you @dedemorton, for the brilliant troubleshooting help. ❤️ |
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Outdated
Show resolved
Hide resolved
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Outdated
Show resolved
Hide resolved
x-pack/auditbeat/processors/sessionmd/docs/add_session_metadata.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: DeDe Morton <[email protected]>
Update: After recent changes, this PR is passing docs-ci. New |
Co-authored-by: Michael Wolf <[email protected]>
@mjwolf, thank you so much for answering remaining questions and suggesting some text. I have committed your work with only minor edits. Please review and let's get this one published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @karenzone and @mjwolf !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎸
StatusThis PR touches every Beat, and requires approval from all Beats code owners. We're missing approvals from obs-ds-hosted-services and @VihasMakwana. Please review so that we can get these docs published. |
@karenzone Vihas is in PTOs until end of the week |
Co-authored-by: Michael Wolf <[email protected]> Co-authored-by: Nick Alayil <[email protected]> Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit 57ff337)
12686 |
…40511) Co-authored-by: Michael Wolf <[email protected]> Co-authored-by: Nick Alayil <[email protected]> Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit 57ff337) Co-authored-by: Karen Metts <[email protected]>
Relates #40186
PREVIEW: https://beats_bk_40252.docs-preview.app.elstc.co/guide/en/beats/auditbeat/master/add-session-metadata.html
Proposed commit message
Adds docs for configuring and enabling
add_session_metadata
processor for Auditbeat. This processor powers the Session View tool in the Elastic Security Platform.ToDo:Find out how (if at all) the different doc location impacts our docs tooling. DONEMost processors and docs live in
https://github.com/elastic/beats/tree/main/libbeat/processors
The
add_session_metadata processor lives in
https://github.com/elastic/beats/tree/main/x-pack/auditbeat/processors/sessionmd`.Partner PR required to get docs building (conf.yaml)
Dependency to break free of gridlock created by changes in two repos: