-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packetbeat/route: fix test failure on Windows 2022 #39822
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO NOT MERGE
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 7, 2024
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
efd6
added
Packetbeat
bugfix
Team:Security-Linux Platform
Linux Platform Team in Security Solution
labels
Jun 7, 2024
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 7, 2024
efd6
added
needs_team
Indicates that the issue/PR needs a Team:* label
backport-v8.14.0
Automated backport with mergify
labels
Jun 7, 2024
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 7, 2024
efd6
changed the title
packetbeat/route: trigger failure
packetbeat/route: fix test failure on Windows 2022
Jun 7, 2024
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
nfritts
approved these changes
Jun 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Windows 2022 appears to have added new text to the output of netsh. The text is interpreted as having three fields. This impact on the behaviour of the field splitting which expects five. - Originally this would cause a panic due to bounds checking. This was fixed in #39757 by erroring on an unexpectedly short line. - The fieldsN helper expects lines to be n fields or longer, but does not terminate on lines with fewer fields. So treat the first blank line found in the table as the end of the table and fix the fieldsN helper. (cherry picked from commit 35f8d09)
6 tasks
efd6
added a commit
that referenced
this pull request
Jun 7, 2024
Windows 2022 appears to have added new text to the output of netsh. The text is interpreted as having three fields. This impact on the behaviour of the field splitting which expects five. - Originally this would cause a panic due to bounds checking. This was fixed in #39757 by erroring on an unexpectedly short line. - The fieldsN helper expects lines to be n fields or longer, but does not terminate on lines with fewer fields. So treat the first blank line found in the table as the end of the table and fix the fieldsN helper. (cherry picked from commit 35f8d09) Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.14.0
Automated backport with mergify
bugfix
Packetbeat
Team:Security-Linux Platform
Linux Platform Team in Security Solution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
panic: runtime error: index out of range [3] with length 3
#39698Use cases
Screenshots
Logs