-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws] Remove unused function newV2Context from input_test.go #39538
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
DO NOT MERGE This is a throwaway commit/PR to test https://github.com/elastic/beats/pull/39538/files
@kaiyan-sheng unfortunately the checks triggered by this PR didn't trigger the failing test described in the issue because it's an optional test that gets triggered only when the Could you please take another look at it? |
@kaiyan-sheng looking at it a bit more with the help of @pkoutsovasilis it seems to me that this PR attempted to fix only the first error:
Looking at a test CI run including the commit it appears that the above error got fixed, yay! Btw @pkoutsovasilis raised a PR #39648 to fix the other
so we can move the discussion there. Thanks again. |
@dliappis ahh yes! Thank you @pkoutsovasilis for the PR to fix the s3input error! |
Proposed commit message
This PR is to remove the unused function
newV2Context
frominput_test.go
. This function also is already declared ininput_integration_test.go
. This should fix error in buildkite:Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.