[7.17](backport #39506) Remove hardcoded module definitions in CI #39527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
For reasons described in [^1], we hard coded `aws` or `kubernetes` for the env var `MODULE`, when no file changes were detected under `modules/` per project. This commit reverts this and allows all module tests to run if no changesets apply. As discussed in [^1], for the tests to run properly (and not go into an infinite loop) if there are no module changes the `MODULE` env var should **not** be set, rather than set to an empty string. This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite. Closes https://github.com/elastic/ingest-dev/issues/2993 [^1]: https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 (cherry picked from commit c91503b) # Conflicts: # .buildkite/metricbeat/pipeline.yml
mergify
bot
added
backport
conflicts
|
Cherry-pick of c91503b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
botelastic
bot
added
the
needs_team
dliappis
removed
conflicts
botelastic
bot
added
the
needs_team
dliappis
added
Team:Ingest-EngProd
and removed
needs_team
|
This pull request doesn't have a |
dliappis
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
For reasons described in 1, we hard coded
awsorkubernetesfor the env varMODULE, when no file changes were detected undermodules/per project.This commit reverts this and allows all module tests to run if no changesets apply. As discussed in 1, for the tests to run properly (and not go into an infinite loop)
if there are no module changes the
MODULEenv var should not be set, rather than set to an empty string.This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite.
Related issues
Closes https://github.com/elastic/ingest-dev/issues/2993
Screenshots
Logs/Tests
aws/macOS/:Windows): https://buildkite.com/elastic/beats/builds/7405#018f666f-797d-415e-a4fa-2911548a6220only failure is x-pack/filebeat Cloud which is unrelated to this PR: https://github.com/elastic/ingest-dev/issues/3312
This is an automatic backport of pull request #39506 done by [Mergify](https://mergify.com).
Footnotes
https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 ↩ ↩2