Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream go plugins helpers #39066

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

kaanyalti
Copy link
Contributor

  • Enhancement

Proposed commit message

Switched from using the archived https://github.com/elastic/go-plugins-helpers to its upstream https://github.com/docker/go-plugins-helpers.

Please explain:

  • WHAT: patterns used, algorithms implemented, design architecture, message processing, etc.
  • WHY: Elastic's go-plugins-helpers package is archived and is not maintained anymore. Replaced it with the upstream repo which is still maintained.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kaanyalti kaanyalti requested a review from a team as a code owner April 18, 2024 21:25
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 18, 2024
Copy link
Contributor

mergify bot commented Apr 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaanyalti? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@kaanyalti kaanyalti added the Team:Fleet Label for the Fleet team label Apr 18, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 18, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 18, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-18T21:29:26.549+0000

  • Duration: 150 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 29390
Skipped 2061
Total 31451

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kaanyalti kaanyalti added the backport-skip Skip notification from the automated backport with mergify label Apr 18, 2024
@kaanyalti kaanyalti merged commit b727b3e into elastic:main Apr 24, 2024
225 checks passed
@kaanyalti kaanyalti deleted the use-upstream-go-plugins-helpers branch April 24, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Fleet Label for the Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants