The elastic-agent-autodiscover library is updated to version 0.6.4, disabling metadata for deployment and cronjob #38571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with 8.11, the elastic-agent-autodiscover library is updated to version 0.6.4, disabling metadata for deployment and cronjob. Pods that will be created from deployments or cronjobs will not have the extra metadata field for kubernetes.deployment or kubernetes.cronjob, respectively. This commit updates the documentation to align with this new change.
asmith-elastic
requested review from
rdner and
fearful-symmetry
and removed request for
a team
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
cmacknz
added
the
Team:Cloudnative-Monitoring
botelastic
bot
removed
the
needs_team
cmacknz
added
needs_team
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
|
👋 Anyone can help @asmith-elastic ? |
gizas
reviewed
Apr 2, 2024
| @@ -178,8 +178,8 @@ Configuration parameters: | |||
| * `node` or `namespace`: Specify labels and annotations filters for the extra metadata coming from node and namespace. By default all labels are included while annotations are not. To change default behaviour `include_labels`, `exclude_labels` and `include_annotations` can be defined. Those settings are useful when storing labels and annotations that require special handling to avoid overloading the storage output. | |||
| Note: wildcards are not supported for those settings. | |||
| The enrichment of `node` or `namespace` metadata can be individually disabled by setting `enabled: false`. | |||
| * `deployment`: If resource is `pod` and it is created from a `deployment`, by default the deployment name is added, this can be disabled by setting `deployment: false`. | |||
| * `cronjob`: If resource is `pod` and it is created from a `cronjob`, by default the cronjob name is added, this can be disabled by setting `cronjob: false`. | |||
| * `deployment`: If resource is `pod` and it is created from a `deployment`, by default the deployment name is not added, this can be enabled by setting `deployment: true`. | |||
There was a problem hiding this comment.
Suggested change
| * `deployment`: If resource is `pod` and it is created from a `deployment`, by default the deployment name is not added, this can be enabled by setting `deployment: true`. | |
| * `deployment`: If resource is `pod` and it is created from a `deployment`. By default the deployment name is not added, this can be enabled by setting `deployment: true`. |
gizas
reviewed
Apr 2, 2024
| * `deployment`: If resource is `pod` and it is created from a `deployment`, by default the deployment name is added, this can be disabled by setting `deployment: false`. | ||
| * `cronjob`: If resource is `pod` and it is created from a `cronjob`, by default the cronjob name is added, this can be disabled by setting `cronjob: false`. | ||
| * `deployment`: If resource is `pod` and it is created from a `deployment`, by default the deployment name is not added, this can be enabled by setting `deployment: true`. | ||
| * `cronjob`: If resource is `pod` and it is created from a `cronjob`, by default the cronjob name is not added, this can be enabled by setting `cronjob: true`. |
There was a problem hiding this comment.
Suggested change
| * `cronjob`: If resource is `pod` and it is created from a `cronjob`, by default the cronjob name is not added, this can be enabled by setting `cronjob: true`. | |
| * `cronjob`: If resource is `pod` and it is created from a `cronjob`. By default the cronjob name is not added, this can be enabled by setting `cronjob: true`. |
gizas
approved these changes
Apr 2, 2024
rdner
approved these changes
Apr 24, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Starting with 8.11, the elastic-agent-autodiscover library is updated to version 0.6.4, disabling metadata for deployment and cronjob. Pods that will be created from deployments or cronjobs will not have the extra metadata field for kubernetes.deployment or kubernetes.cronjob, respectively. This commit updates the documentation to align with this new change in 8.11.
This commit should also be back-ported to version 8.11.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues