[libbeat] Cache processor docs and memory fixes. #38561
Conversation
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💔 Build Failed
Failed CI Stepscc @marc-gr |
💔 Build Failed
Failed CI Stepscc @marc-gr |
💔 Build Failed
Failed CI Stepscc @marc-gr |
marc-gr
added
the
Team:Security-Service Integrations
botelastic
bot
removed
the
needs_team
marc-gr
added
needs_team
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
/test |
There was a problem hiding this comment.
I think interval is better term here. Also see this comment from the addition. Suggest changing the documentation rather than the code.
That was my initial option, too. The thing that made it for period at the end was mainly that anyone using this setting will have it set up as |
marc-gr
changed the title
write_period to write_interval.
I would prefer to just ignore them, but Andrew may disagree.
Heap sort is not lexical sort, so this is fine. We don't care about the order of the heap entries, just that the heap behaves like a heap. |
|
/test |
|
/test |
1 similar comment
|
/test |
|
I think the failures in metricbeat-pythonIntegTest are caused by #38539. |
andrewkroh
removed
backport-v8.11.0
Change cache processor documentation from write_period to write_interval. Fix expires heap cleanup on partial file writes: popping the expiries heap completely on every partial write caused a panic on the following put operations at the time of expiry check. Fix expires infinite growth when large TTLs and recurring keys are cached: when TTLs are large and keys are recurrent, we kept track of an arbitrary amount of expiry heap entries for the same key, causing memory to grow. (cherry picked from commit b1e4abc)
Change cache processor documentation from write_period to write_interval. Fix expires heap cleanup on partial file writes: popping the expiries heap completely on every partial write caused a panic on the following put operations at the time of expiry check. Fix expires infinite growth when large TTLs and recurring keys are cached: when TTLs are large and keys are recurrent, we kept track of an arbitrary amount of expiry heap entries for the same key, causing memory to grow.
…es. (#38745) Change cache processor documentation from write_period to write_interval. Fix expires heap cleanup on partial file writes: popping the expiries heap completely on every partial write caused a panic on the following put operations at the time of expiry check. Fix expires infinite growth when large TTLs and recurring keys are cached: when TTLs are large and keys are recurrent, we kept track of an arbitrary amount of expiry heap entries for the same key, causing memory to grow. (cherry picked from commit b1e4abc) --------- Co-authored-by: Marc Guasch <[email protected]>
|
@Mergifyio backport 8.12 |
✅ Backports have been created
|
Change cache processor documentation from write_period to write_interval. Fix expires heap cleanup on partial file writes: popping the expiries heap completely on every partial write caused a panic on the following put operations at the time of expiry check. Fix expires infinite growth when large TTLs and recurring keys are cached: when TTLs are large and keys are recurrent, we kept track of an arbitrary amount of expiry heap entries for the same key, causing memory to grow. (cherry picked from commit b1e4abc)
…39001) * [libbeat] Cache processor docs and memory fixes. (#38561) Change cache processor documentation from write_period to write_interval. Fix expires heap cleanup on partial file writes: popping the expiries heap completely on every partial write caused a panic on the following put operations at the time of expiry check. Fix expires infinite growth when large TTLs and recurring keys are cached: when TTLs are large and keys are recurrent, we kept track of an arbitrary amount of expiry heap entries for the same key, causing memory to grow. (cherry picked from commit b1e4abc) * Update CHANGELOG.next.asciidoc --------- Co-authored-by: Marc Guasch <[email protected]>
Proposed commit message
write_periodtowrite_interval.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.