metricbeat/module/rabbitmq/queue: Fix data type for consumers.utilisation.pct

[andrewkroh]

Proposed commit message

Fix mapping type for rabbitmq.queue.consumers.utilisation.pct to be scaled_float instead of long because the values range on [0.0, 1.0]. Previously, truncation converted the value to an integer so it either reported zero or one.

There was a bug in the unit tests that did not catch this until we updated to testify 1.9.0 (stretchr/testify#1531). This PR removes the temporary testify v1.8.4 pin.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Blocks go.mod - bump to github.com/lestrrat-go/jwx/v2 v2.0.21 #38346
• Relates assert: Fix EqualValues to handle overflow/underflow stretchr/testify#1531

Logs

    queue_test.go:58: 
        	Error Trace:	C:/Users/jenkins/workspace/PR-38346-3-4409e966-4007-43a3-9905-b28d677060d2/src/github.com/elastic/beats/metricbeat/module/rabbitmq/queue/queue_test.go:58
        	Error:      	Not equal: 
        	            	expected: float64(0.7)
        	            	actual  : int64(0)
        	Test:       	TestFetchEventContents
--- FAIL: TestFetchEventContents (0.01s)

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2024-03-20T01:54:36.192+0000

• Duration: 183 min 36 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28619
Skipped	1906
Total	30525

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[shmsr]

Left one comment. Otherwise, it looks good.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8df4146

History

• 💚 Build #2364 succeeded fa6fa56

cc @andrewkroh

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8df4146

History

• 💚 Build #1134 succeeded fa6fa56

cc @andrewkroh

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8df4146

History

• 💚 Build #1092 succeeded fa6fa56

cc @andrewkroh

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8df4146

History

• 💚 Build #1527 succeeded fa6fa56

cc @andrewkroh

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8df4146

History

• 💚 Build #2371 succeeded fa6fa56

cc @andrewkroh

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8df4146

History

• 💚 Build #1089 succeeded fa6fa56

cc @andrewkroh

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8df4146

History

• 💚 Build #1102 succeeded fa6fa56

cc @andrewkroh

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8df4146

History

• 💚 Build #3582 succeeded fa6fa56

cc @andrewkroh