Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat][websocket] - Fixed flakey regex test #37990

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[filebeat][websocket] - Fixed flakey regex test #37990

merged 2 commits into from
Feb 12, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Feb 12, 2024 •
edited
Loading

Type of change

  • Bug

Proposed commit message

A particular config test was flakey in nature and went unnoticed due to its flakeyness but ultimately caused build failures in the ci pipelines - #37970. This error happened as there were 2 invalid regexes in a config map and either one would fail causing 2 different errors. To fix this only one deterministic path of failure now exists by keeping one regex valid and the other invalid.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 12, 2024
@ShourieG ShourieG changed the title removing flakey regex test [filebeat][websocket] - Removed flakey regex test Feb 12, 2024
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Feb 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 12, 2024
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label bugfix labels Feb 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 12, 2024
@ShourieG ShourieG self-assigned this Feb 12, 2024
@ShourieG ShourieG marked this pull request as ready for review February 12, 2024 18:21
@ShourieG ShourieG requested a review from a team as a code owner February 12, 2024 18:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG enabled auto-merge (squash) February 12, 2024 18:21
andrewkroh
andrewkroh reviewed Feb 12, 2024
View reviewed changes
x-pack/filebeat/input/websocket/config_test.go Outdated
},
"url": "wss://localhost:443/v1/stream",
},
wantErr: fmt.Errorf("failed to check regular expressions: error parsing regexp: unexpected ): `(?i)(xq>)d+)` accessing config"),
Copy link
Member

@andrewkroh andrewkroh Feb 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the root cause of the flakyness that there are two possible errors that can occur given that both regular expressions are invalid? Rather than removing the test entirely it seems like better solution would be to address the non-determinism by removing solutions(or making it valid).

Copy link
Contributor Author

@ShourieG ShourieG Feb 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewkroh Yes absolutely, initial approach was immature, have updated the test accordingly, and now only one specific failure should happen.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 12, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@ShourieG ShourieG changed the title [filebeat][websocket] - Removed flakey regex test [filebeat][websocket] - Fixed flakey regex test Feb 12, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @ShourieG

@ShourieG ShourieG requested a review from andrewkroh February 12, 2024 18:40
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 12, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 137 min 33 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@ShourieG ShourieG merged commit 7ac96a8 into elastic:main Feb 12, 2024
33 checks passed
@ShourieG ShourieG deleted the websocket/remove_flakey_test branch February 12, 2024 22:19
This was referenced Feb 13, 2024
Closed
Closed
@andrewkroh andrewkroh mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@ShourieG ShourieG

Labels
bugfix Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShourieG @elasticmachine @andrewkroh